Update network policy egress in remote development agent configs
What does this MR do and why?
Issue: Backend: Updates to agent configuration updates... (#427235 - closed)
Depends on: Add egress ip options in remote development age... (!135497 - merged)
Update network policy egress in remote development agent configs
Set all workspaces of the agent to force include all resources when the configuration of the agent is updated.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Configure an agent with the following configuration
remote_developemnt:
enabled: true
network_policy:
enabled: true
egress:
- allow: '0.0.0.0/0
except:
- '10.0.0.0/8'
- allow: '10.0.0.0/32
- Verify that the
network_policy_egress
is set to[{ "allow": "0.0.0.0/0", "except": ["10.0.0.0/8"] }, { "allow": "10.0.0.0/32" }]
in theremote_development_agent_configs
table for the given agent. - Verify that all the
workspaces
for the given agent haveforce_include_all_resources: true
immediately after the update.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Category:Remote Development featureaddition groupide typefeature labels
assigned to @vtak
added devopscreate sectiondev labels
mentioned in issue #427235 (closed)
changed milestone to %16.6
- Resolved by Alper Akgun
- Resolved by Alper Akgun
- Resolved by Vishal Tak
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for fd798cccexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 215 | 0 | 10 | 0 | 225 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for fd798cccexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 543 | 0 | 52 | 0 | 595 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 569 | 0 | 56 | 0 | 625 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 308 commits
-
345437e5...c7b01ff1 - 306 commits from branch
master
- 6b86453f - Update network policy egress in remote development agent configs
- 7f8b6b9f - Update noinspection comments to add issue link
-
345437e5...c7b01ff1 - 306 commits from branch
- Resolved by Alper Akgun
- Resolved by Vishal Tak
@cwoolley-gitlab - Can you please review and merge this one?
requested review from @cwoolley-gitlab
changed milestone to %16.7
added missed:16.6 label
mentioned in merge request gitlab-org/cluster-integration/gitlab-agent!1167 (merged)
added 2276 commits
-
7f8b6b9f...89e68d51 - 2274 commits from branch
master
- 62356e3e - Update network policy egress in remote development agent configs
- 65eb409d - Update noinspection comments to add issue link
-
7f8b6b9f...89e68d51 - 2274 commits from branch
- Resolved by Alper Akgun
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ddieulivol
(UTC+1, 4.5 hours behind author)
@mayra-cabrera
(UTC-6, 11.5 hours behind author)
~"Create::IDE - Remote Development Backend" Reviewer review is optional for ~"Create::IDE - Remote Development Backend" @cwoolley-gitlab
(UTC-8, 13.5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @a_akgun
removed review request for @cwoolley-gitlab
- Resolved by Alper Akgun
@a_akgun
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
- Resolved by Alper Akgun
enabled an automatic merge when the pipeline for ba2c9d60 succeeds
Generated bygitlab_quality-test_tooling
. Please share your feedback and suggestions.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #5601094211 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 568.93 s < 27.12 s #5601184105 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 542.28 s < 27.12 s - A deleted user
added rspec:slow test detected label
enabled an automatic merge when the pipeline for a628cde0 succeeds
mentioned in commit adb8006d
mentioned in issue #432766 (closed)
mentioned in merge request !137751 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label