Skip to content
Snippets Groups Projects

Update network policy egress in remote development agent configs

Merged Vishal Tak requested to merge vtak/egress_agent_config_update into master
All threads resolved!

What does this MR do and why?

Issue: Backend: Updates to agent configuration updates... (#427235 - closed)

Depends on: Add egress ip options in remote development age... (!135497 - merged)

Related to: Add remote development network policy egress pr... (gitlab-org/cluster-integration/gitlab-agent!1167 - merged)

Update network policy egress in remote development agent configs

Set all workspaces of the agent to force include all resources when the configuration of the agent is updated.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure an agent with the following configuration
remote_developemnt:
  enabled: true
  network_policy:
    enabled: true
    egress:
    - allow: '0.0.0.0/0
      except:
      - '10.0.0.0/8'
    - allow: '10.0.0.0/32
  1. Verify that the network_policy_egress is set to [{ "allow": "0.0.0.0/0", "except": ["10.0.0.0/8"] }, { "allow": "10.0.0.0/32" }] in the remote_development_agent_configs table for the given agent.
  2. Verify that all the workspaces for the given agent have force_include_all_resources: true immediately after the update.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vishal Tak

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vishal Tak
  • Vishal Tak
  • Vishal Tak changed the description

    changed the description

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for fd798ccc

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
    | Create           | 40     | 0      | 7       | 0     | 47    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 215    | 0      | 10      | 0     | 225   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for fd798ccc

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 543    | 0      | 52      | 0     | 595   | ✅     |
    | Govern           | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Plan             | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 569    | 0      | 56      | 0     | 625   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Vishal Tak deleted the vtak/egress_agent_config_db branch. This merge request now targets the master branch

    deleted the vtak/egress_agent_config_db branch. This merge request now targets the master branch

  • Vishal Tak added 308 commits

    added 308 commits

    • 345437e5...c7b01ff1 - 306 commits from branch master
    • 6b86453f - Update network policy egress in remote development agent configs
    • 7f8b6b9f - Update noinspection comments to add issue link

    Compare with previous version

  • Vishal Tak
  • Vishal Tak requested review from @cwoolley-gitlab

    requested review from @cwoolley-gitlab

  • Vishal Tak changed the description

    changed the description

  • 🤖 GitLab Bot 🤖 changed milestone to %16.7

    changed milestone to %16.7

  • Vishal Tak added 2276 commits

    added 2276 commits

    • 7f8b6b9f...89e68d51 - 2274 commits from branch master
    • 62356e3e - Update network policy egress in remote development agent configs
    • 65eb409d - Update noinspection comments to add issue link

    Compare with previous version

  • Vishal Tak
  • A deleted user added backend label

    added backend label

  • Contributor
    1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @ddieulivol profile link current availability (UTC+1, 4.5 hours behind author) @mayra-cabrera profile link current availability (UTC-6, 11.5 hours behind author)
    ~"Create::IDE - Remote Development Backend" Reviewer review is optional for ~"Create::IDE - Remote Development Backend" @cwoolley-gitlab profile link current availability (UTC-8, 13.5 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Vishal Tak requested review from @a_akgun

    requested review from @a_akgun

  • Vishal Tak removed review request for @cwoolley-gitlab

    removed review request for @cwoolley-gitlab

  • Alper Akgun approved this merge request

    approved this merge request

  • Alper Akgun
  • Alper Akgun resolved all threads

    resolved all threads

  • Alper Akgun enabled an automatic merge when the pipeline for ba2c9d60 succeeds

    enabled an automatic merge when the pipeline for ba2c9d60 succeeds

  • Vishal Tak aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Vishal Tak added 2 commits

    added 2 commits

    • 3b4bad9b - Update noinspection comments to add issue link
    • fd798ccc - Update network policy egress in remote development agent configs

    Compare with previous version

  • Alper Akgun approved this merge request

    approved this merge request

  • Vishal Tak resolved all threads

    resolved all threads

  • Contributor

    :tools: Generated by gitlab_quality-test_tooling.

    :recycle: Please share your feedback and suggestions.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #5601094211 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 568.93 s < 27.12 s
    #5601184105 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 542.28 s < 27.12 s
  • A deleted user added rspec:slow test detected label
  • Alper Akgun enabled an automatic merge when the pipeline for a628cde0 succeeds

    enabled an automatic merge when the pipeline for a628cde0 succeeds

  • merged

  • Alper Akgun mentioned in commit adb8006d

    mentioned in commit adb8006d

  • mentioned in issue #432766 (closed)

  • Vishal Tak mentioned in merge request !137751 (merged)

    mentioned in merge request !137751 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading