Skip to content

Don't turn on new nav user setting in specs

Lukas 'ai-pi' Eipert requested to merge leipert-remove-use_new_navigation-from-specs into master

What does this MR do and why?

Don't turn on new nav user setting in specs

All the specs run with the new navigation now. So we can delete a few duplicate specs and some use_new_navigation: true from user objects.

Remove no_super_sidebar trait from user factory

This trait was temporary. We fixed all specs to run with the new nav (context: #420121 (closed)), so we can remove this trait now.

Change Super Sidebar specs to be shared examples

All specs run with the new sidebar now. We can convert this spec to be a shared example, being run in both user / admin context.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Run the specs locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hordur Freyr Yngvason

Merge request reports