Fix regexp for CI components paths
What does this MR do and why?
related to Fix regexp to scan for component files (#430344 - closed)
The regexp to find CI components was too strict and didn't allow for more than 1 -
to be in the component name.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @fabiopitino
changed milestone to %16.6
removed workflowin review label
mentioned in issue #430344 (closed)
- Resolved by Avielle Wolfe
@lauraX can you please review?
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ghinfey
(UTC+0, same timezone as author)
@kerrizor
(UTC-8, 8 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @drew
(UTC+0, same timezone as author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in epic &7462
added pipeline:mr-approved label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 98b17e12expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 9 | 0 | 210 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 98b17e12expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 539 | 0 | 101 | 0 | 640 | ✅ | | Govern | 303 | 0 | 12 | 6 | 315 | ❗ | | Manage | 27 | 13 | 10 | 14 | 50 | ❌ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 226 | 0 | 17 | 3 | 243 | ❗ | | Verify | 155 | 1 | 9 | 0 | 165 | ❌ | | Plan | 249 | 0 | 10 | 0 | 259 | ✅ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Monitor | 39 | 0 | 7 | 0 | 46 | ✅ | | Fulfillment | 8 | 0 | 69 | 0 | 77 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1702 | 14 | 271 | 23 | 1987 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
@fabiopitino Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.added pipeline:run-all-e2e label
enabled an automatic merge when the pipeline for 123e998b succeeds
Setting label(s) Category:Pipeline Composition based on grouppipeline authoring.
added Category:Pipeline Composition label
added 160 commits
-
0b502057...d87f76c4 - 159 commits from branch
master
- 98b17e12 - Fix regexp for CI components paths
-
0b502057...d87f76c4 - 159 commits from branch
enabled an automatic merge when the pipeline for 93c81018 succeeds
- Resolved by Laura Montemayor
@lauraX FYI - I'm applying verify-reviewnot impacted
added verify-reviewnot impacted label
@avielle, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 80970c6a
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)
mentioned in epic gitlab-org#7462