Skip to content

Reduce duplicate job key TTL from 6 hrs to 10 mins

Sylvester Chin requested to merge sc1-shorten-duplicate-key-ttl into master

What does this MR do and why?

This MR reduces the duplicate job key TTL from 6 hrs to 10 mins. This reduces the delay if duplicate job keys were left dangling in the Redis store.

The job key can be left dangling due to deletion failure and this prevents any other jobs of the same class and args to be scheduled for the next 6 hours. Since our scheduling target is 1 minute for low urgency jobs and execution latency requirement is 5 minutes (https://docs.gitlab.com/ee/development/sidekiq/worker_attributes.html#job-urgency), 6 hours is too long.

See #344488

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports