Replace GlFormSelect by GlCollapsibleListbox
What does this MR do and why?
In the group and project member invite modal, we replace GlFormSelect by GlCollapsibleListbox. This is in preparation to display custom roles.
Removed the access-level
event because it is not necessary.
Changelog: changed
EE: true
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to
/groups/flightjs/-/group_members
as an admin or group owner - Select
Invite a member
- Observe the
Select a role
dropdown.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.6
assigned to @eduardosanz
added devopsgovern sectionsec labels
- Resolved by Doug Stull
@dstull, do you think you could do the initial review of this MR? Thanks!
- Resolved by Eduardo Sanz García
added pipeline:mr-approved label
- Resolved by Eduardo Sanz García
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 99c89368expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 99c89368expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 2 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 0 | 25 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 99c89368expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Create | 539 | 0 | 103 | 0 | 642 | ✅ | | Govern | 298 | 0 | 17 | 9 | 315 | ❗ | | Manage | 40 | 0 | 10 | 14 | 50 | ❗ | | Package | 226 | 0 | 17 | 3 | 243 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 249 | 0 | 10 | 0 | 259 | ✅ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | Fulfillment | 8 | 0 | 69 | 1 | 77 | ❗ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Verify | 138 | 0 | 27 | 0 | 165 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 39 | 0 | 7 | 0 | 46 | ✅ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1693 | 0 | 296 | 27 | 1989 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 151 commits
-
b809bbce...51a9a33a - 150 commits from branch
master
- bf21890f - Replace GlFormSelect by GlCollapsibleListbox
-
b809bbce...51a9a33a - 150 commits from branch
Thanks for the quick review, @dstull!
I acted on your suggestion and removed
isLoadingRole
.- Resolved by Doug Stull
requested review from @ekigbo
mentioned in issue #393239 (closed)
removed review request for @ekigbo
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.Testid Selectors
The following changed lines in this MR contain testid selectors:
- file
app/assets/javascripts/invite_members/components/invite_modal_base.vue
: -
-
data-testid="access-level-dropdown"
-
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @minahilnichols
(UTC-5, 6 hours behind author)
@ealcantara
(UTC+1, same timezone as author)
QA @john.mcdonnell
(UTC+0, 1 hour behind author)
Maintainer review is optional for QA test for spec/features/*
@hmuralidhar
(UTC+11, 10 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded pipeline:run-all-e2e label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a3acbe14 and 99c89368
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.learn_gitlab.show 447.65 KB 552.59 KB +104.94 KB 23.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for a3acbe14. So we have used data from: 47104a78.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Doug Stull
requested review from @ekigbo
added 1082 commits
-
4c39b570...09349500 - 1080 commits from branch
master
- 99837197 - Replace GlFormSelect by GlCollapsibleListbox
- 0dd7b908 - Fix broken tests
-
4c39b570...09349500 - 1080 commits from branch
- A deleted user
added QA label
- Resolved by Doug Stull
requested review from @hmuralidhar
removed Background Processing label
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @ekigbo
changed milestone to %16.7
- Resolved by Doug Stull
@ekigbo
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
removed review request for @hmuralidhar
@dstull, please, could you re-approve and merge this MR? Thanks!
requested review from @dstull