Skip to content

Refactor Auth Helper SAML providers method

Drew Blessing requested to merge dblessing_auth_helper_refactor into master

What does this MR do and why?

Related to #420766 (closed).

When checking for SAML providers, we can avoid loading up the SAML config and applying default args, when we only need to determine which SAML providers are configured, if any. This refactor will facilitate adding SAML default configuration in a subsequent MR (avoids a recursive dependency). This is not a user-facing change.

This also updates some specs to use a clean, low level stub rather than directly stubbing various classes.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Drew Blessing

Merge request reports