Skip to content

Draft: Unbox activity notes

Sascha Eggenberger requested to merge issuables-activity-redesign into master

What does this MR do and why?

Unboxes the top level comments (notes) but keeps the "boxyness" for threaded comments:

  • Unboxes top level comments (notes)
  • Keeps replies "boxed"
  • Evens spacings between system activities and user comments
  • Unifies the "edited" text appearance
  • Bonus: Simplifies CSS used quite a bit (tech debt)

This would still benefit from a CSS rewrite/adjustment as a follow-up measure.

Screenshots or screen recordings

Issuables

Before After
before_issue issue_after

Epics

Before After
before_epic epic_after

MRs

Before After
mr_before mr_after

MR diff view

Before After
diff_before diff_after

Work items

Before After
work_items_before work_items_after

Alignment

Vertical alignment
Alignment

How to set up and validate locally

  1. Go to an issue (e.g. http://gdk.test:3000/flightjs/Flight/-/issues/3)
  2. Go to an epic (e.g. http://gdk.test:3000/groups/flightjs/-/epics/5)
  3. Go to an MR (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3)
  4. Go to an MR diff view (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3/diffs)
  5. Go to an Work item [Task/Objective/Key result] (e.g. http://gdk.test:3000/flightjs/Flight/-/work_items/49)
  6. Go to an commit (e.g. http://gdk.test:3000/flightjs/Flight/-/commit/f3d5120015b8286a5fbef20e78a8daa46524e3b7)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to ✂️ UX Paper Cuts 16.6 → Activity (#425468 - closed), #424396 (closed)

Edited by Sascha Eggenberger

Merge request reports