Skip to content

Remove dup metrics_external_dashboard_url

Luke Bennett requested to merge remove-dup-metrics_external_dashboard_url into master

What does this MR do?

Fix master, remove dupe method

Offenses:

app/helpers/projects_helper.rb:352:3: W: Lint/DuplicateMethods: Method ProjectsHelper#metrics_external_dashboard_url is defined at both app/helpers/projects_helper.rb:324 and app/helpers/projects_helper.rb:352.
  def metrics_external_dashboard_url
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

11859 files inspected, 1 offense detected

https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/221741576

closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11830

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports