Skip to content

Remove idempotent! for bulk cron workers

Dmitry Gruzd requested to merge remove-idempotent-flag-from-bulk-cron-workers into master

What does this MR do and why?

This MR removes idempotent! from ElasticIndexBulkCronWorker and ElasticIndexInitialBulkCronWorker. The groupglobal search has been disproportionally hit with duplicate keys issues, which includes incidents and customers escalations. The latest example is https://gitlab.com/gitlab-com/enablement-sub-department/section-enable-request-for-help/-/issues/47#note_1628674627.

That is because we have very limited set of arguments (empty and 0 to 15) for the bulk cron workers.

It is safe to remove for these workers because they are cron workers and because we use Gitlab::ExclusiveLeaseHelpers#in_lock to prevent concurrent execution for the same shard.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dmitry Gruzd

Merge request reports