You need to sign in or sign up before continuing.
Move application theme classes to html root element from body
What does this MR do and why?
gitlab-ui!3724 (merged) introduces automated :root.gl-dark selector for generated CSS custom properties from design tokens. In order to consume CSS custom properties from gitlab-ui design tokens we need to move the .gl-dark class from <body> to <html>.
This change updates all user_application_theme to move form <body> to <html>. This should allow future CSS custom properties for user preference themes to be attached to the :root element.
There should be no visual changes.
Screenshots or screen recordings
CleanShot_2023-11-02_at_11.59.38
How to set up and validate locally
- Toggle themes in user preferences
- Themes should apply as expected
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #430052 (closed)
Edited by Scott de Jonge