Fix groups specs with super sidebar enabled
What does this MR do and why?
Updates a few groups-related specs to pass when the super sidebar is enabled.
Screenshots or screen recordings
No visual change.
How to set up and validate locally
bundle exec rspec spec/features/groups/container_registry_spec.rb
bundle exec rspec spec/features/groups/dependency_proxy_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #420121 (closed)
Merge request reports
Activity
changed milestone to %16.6
assigned to @pgascouvaillancourt
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer test for spec/features/*
@akotte
(UTC+5.5, 9.5 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 732 commits
-
25d8a374...33f79cfc - 731 commits from branch
master
- 11363481 - Fix groups specs with super sidebar enabled
-
25d8a374...33f79cfc - 731 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Sylvester Chin
@a_luna could you review this please?
requested review from @a_luna
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 014f76be succeeds
mentioned in commit fec40afe
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label