Fix view wiki pages that contain empty spaces in their file names
requested to merge gitlab-community/gitlab:391264-dcf-unable-to-view-wiki-pages-in-ui-that-contain-empty-spaces into master
What does this MR do and why?
It allows GitLab Wiki to open files that contain spaces in their names instead of redirecting to the creation page.
It fixes this issue #391264 (closed).
To do so, some changes were applied:
- When listing or finding wiki pages, the returned page path is the raw path and no more a forced sluggified version of it. Doing so we can show, edit and delete pages that contain spaces in their names.
When creating or editing wiki pages, I kept the logic that sluggify the page title to use it as the page path.
Screenshots or screen recordings
When browsing through wiki pages | Comments |
---|---|
We can access all pages. Take a look at the browser URL. |
When editing the content of a wiki page whose original path does not contain spaces | Comments |
---|---|
We can update the page content and the original page path does not change. |
When editing the content of a wiki page whose original path containa spaces | Comments |
---|---|
We can update the page content and the original page path changes to a sluggified version. |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #391264 (closed)
Edited by Dannyel Cardoso da Fonseca