Use new navigation in more specs
What does this MR do and why?
Use new navigation in more specs
Part of #420121 (closed).
Screenshots or screen recordings
n/a
How to set up and validate locally
- Does the pipeline pass?
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #420121 (closed)
Merge request reports
Activity
changed milestone to %16.6
assigned to @markrian
marked this merge request as draft from 6af3deb1
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f8689415expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Create | 32 | 0 | 5 | 0 | 37 | ✅ | | Govern | 45 | 0 | 0 | 0 | 45 | ✅ | | Verify | 32 | 0 | 0 | 1 | 32 | ❗ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 180 | 0 | 6 | 1 | 186 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for f8689415expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 0 | 25 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for f8689415expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 130 | 0 | 36 | 0 | 166 | ✅ | | Manage | 40 | 0 | 10 | 1 | 50 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 170 | 0 | 46 | 1 | 216 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !134840 (merged)
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
@hmerscher Would you review the backend/test changes here, please?
@elwyn-gitlab Would you review the frontend changes here, please?
requested review from @hmerscher and @elwyn-gitlab
requested review from @ohoral and removed review request for @elwyn-gitlab
added pipeline:mr-approved label
Generated bygitlab_quality-test_tooling
. Please share your feedback and suggestions.
Slow tests detected in this merge request, might be related with changed RSpec files.Job File Name Duration Expected duration #5432175462 ee/spec/models/ee/group_spec.rb#L702
Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 49.19 s < 45.4 s #5438931183 ee/spec/models/ee/group_spec.rb#L702
Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 60.19 s < 45.4 s #5444403260 ee/spec/models/ee/group_spec.rb#L702
Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 53.86 s < 45.4 s - A deleted user
added rspec:slow test detected label
- Resolved by Douglas Barbosa Alexandre
removed review request for @hmerscher
requested review from @dbalexandre
mentioned in issue gitlab-com/www-gitlab-com#31164 (closed)
1 Warning This Merge Request needs to be labelled with frontend, backend. Please request a reviewer or maintainer to add them. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @rkumar555
(UTC+1, 1 hour ahead of author)
@DylanGriffith
(UTC+11, 11 hours ahead of author)
frontend @janis
(UTC+1, 1 hour ahead of author)
@ohoral
(UTC+2, 2 hours ahead of author)
test for spec/features/*
@sliaquat
(UTC+5, 5 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerenabled an automatic merge when the pipeline for f28f703b succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b620261c and f8689415
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.11 MB 4.11 MB -1.24 KB -0.0 % mainChunk 3.06 MB 3.06 MB -1.24 KB -0.0 %
Note: We do not have exact data for b620261c. So we have used data from: b3ac1d30.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in commit 9a5729b7
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label