Fix save password form dialog on CI/CD Registration token

changed milestone to %16.6

added UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev typemaintenance labels

assigned to @seggenberger

mentioned in issue #427896 (closed)

changed the description

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for d2fb0284

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
| Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 201    | 0      | 9       | 0     | 210   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for 1550bb3a

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 20     | 0      | 4       | 0     | 24    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

76723bf5 - Fix save password form dialog on CI/CD Registration token

Compare with previous version

Hey @syarynovskyi can you do the frontend review? TY

requested review from @syarynovskyi

added 1 commit

e7acf523 - Fix save password form dialog on CI/CD Registration token

Compare with previous version

approved this merge request

added pipeline:mr-approved label

requested review from @justin_ho and removed review request for @syarynovskyi

removed review request for @justin_ho

added 1 commit

b899e799 - Fix save password form dialog on CI/CD Registration token

Compare with previous version

Hey @mrincon can you do the approval for devopsverify ?

requested review from @mrincon

requested review from @justin_ho

	1 Warning
	This MR changes code in `ee/`, but its Changelog commit is missing the `EE: true` trailer. Consider adding it to your Changelog commits.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	`@syarynovskyi` (UTC+2, 1 hour ahead of author)	`@justin_ho` (UTC+7, 6 hours ahead of author)
test for `spec/features/*`	`@hmehra` (UTC+11, 10 hours ahead of author)	Maintainer review is optional for test for `spec/features/*`

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 0c485b70 and d2fb0284

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.11 MB	4.11 MB	-	0.0 %
mainChunk	3.06 MB	3.06 MB	-	0.0 %

Significant Growth: 9

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.admin.applications	85.72 KB	96.05 KB	+10.32 KB	12.0 %
pages.groups.saml_providers	291.26 KB	301.58 KB	+10.32 KB	3.5 %
pages.groups.saml_providers.saml_members.store	291.27 KB	301.59 KB	+10.32 KB	3.5 %
pages.groups.settings.access_tokens	403.91 KB	414.23 KB	+10.32 KB	2.6 %
pages.groups.settings.applications	189.7 KB	200.02 KB	+10.32 KB	5.4 %
pages.groups.sso	246.67 KB	256.99 KB	+10.32 KB	4.2 %
pages.oauth.applications	68.71 KB	79.03 KB	+10.32 KB	15.0 %
pages.projects.settings.access_tokens	441.59 KB	451.91 KB	+10.32 KB	2.3 %
pages.projects.settings.analytics	385.25 KB	395.57 KB	+10.32 KB	2.7 %

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@leipert, @markrian, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

Note: We do not have exact data for 0c485b70. So we have used data from: f3ab5c45.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Read more about how this report works.

Generated by Danger

@seggenberger This component uses input_copy_toggle_visibility.vue internally. Do you think we could find a way to fix this globally there? I bet we would see the same problem in our forms that use it:

Googling didn't immediately reveal a super easy way to prevent this behavior, so maybe we can research a bit more?

requested review from @elwyn-gitlab and removed review request for @mrincon

added 1 commit

9b900049 - Fix save password form dialog on CI/CD Registration token

Compare with previous version

requested review from @mrincon

requested review from @dcouture and removed review request for @mrincon

added Application Security label

removed review request for @dcouture

added 1 commit

764f21cf - Fix save password form dialog on CI/CD Registration token

Compare with previous version

added 1 commit

1550bb3a - Fix save password form dialog on CI/CD Registration token

Compare with previous version

Generated by gitlab_quality-test_tooling.

Please share your feedback and suggestions.

Slow tests detected in this merge request, might be related with changed RSpec files.

Job	File	Name	Duration	Expected duration
#5447773911	`ee/spec/models/ee/group_spec.rb#L702`	Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups	49.74 s	< 45.4 s