Skip to content

Draft: Render 404 for XHR in route_not_found

Malcolm Locke requested to merge mallocke/modify-xhr-route-not-found-response into master

What does this MR do and why?

Render 404 for XHR in route_not_found

Previously this would redirect JSON XHR requests with an HTML response and a 3xx redirect to the HTML login page.

With this change a 404 response is rendered. The correct content type for the response is already implemented in the not_found method so requests will receive an appropriate response.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports