Skip to content

Patching cases where /assets endpoint has no redirection

Max Fan requested to merge patch_github_attachment_importer into master

What does this MR do and why?

Currently there's some errors raised on attachments imports when scraping github markdown.

image.png

This MR changes this, so when the response is 200 it continues with downloading attachment from the url

Screenshots or screen recordings

N/A

Before After

How to set up and validate locally

This is tricky as there's no reproducible steps. Github's internal image storage mechanics are not visible to us, so we'll have to rely on customer supports to understand what's happening.

There has been no customer reports as of now.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Relates to #430299 (closed)

Edited by Max Fan

Merge request reports