Skip to content

Ignore jobs without runners when tracking failed jobs

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/429668/fix-null-reference into master

What does this MR do and why?

This MR changes the logic in Ci::InstanceRunnerFailedJobs.track_job? so that it ignores jobs when they reference a nil runner. This fixes scenarios like https://new-sentry.gitlab.net/organizations/gitlab/issues/344228/?project=3.

  • Changelog: fixed
  • EE: true

Fixes #429668 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports