Downgrade vue-apollo to prevent auto-restarting subscriptions on error
What does this MR do and why?
Remove obscure propsData usage in provide (!131712 - merged) • Lorenz van Herwaarden • 16.5 is being backported such that vue-apollo is downgraded to v3.0.7. Initially we upgraded vue-apollo to v3.1.1 because the upgrade contained a fix that allowed us to get rid of some tech debt. However, in v3.1.0 a fix was made in vue-apollo that automatically restarts graphql subscriptions on error.
It seems the automatic restarting is too aggressive and caused this incident which led to this investigation.
Conclusion: "Customers can experience increased Puma CPU saturation as well as increased log messages".
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).