Skip to content

Resolve "Datateam danger plugin - only return removed lines"

Justin Wong requested to merge 429496-datateam-danger-plugin-only-return-mr-s-where-db-structure-sql-has-removed-lines into master

Closes #429496 (closed)

What does this MR do and why?

The goal of this MR is to eliminate the number of false positives that show up from the Danger Bot.

There are a number of false positives that show up, and not all of them would be easily rectified.

However, one easy win would be removing any MR's that only have structure.yml additions.

Here is an example of a MR diff with only additions.

To remove these type of MR's from showing up, an additional regex has been added that checks for each modified_line for the presence of a - character, which indicates that a line has been removed and the file should be indeed flagged.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #429496 (closed)

Edited by Justin Wong

Merge request reports