Drop namespaces_on_ldap_sync_last_successful_update_at for Gitlab.com

changed milestone to %16.6

added Category:Database GitLab.com Resource Saturation bugperformance devopsdata stores groupdatabase priority2 sectioncore platform severity2 typebug workflowin dev labels

assigned to @praba.m7n

changed title from Draft: Drop index_namespaces_on_ldap_sync_last_successful_update_at for Gitlab.com to Draft: Drop namespaces_on_ldap_sync_last_successful_update_at for Gitlab.com

added docs-only label

mentioned in commit b649aa6f

added 2168 commits

32e89459...0ac8e8e1 - 2167 commits from branch master
b649aa6f - Drops unused index from namespaces

Compare with previous version

added database databasereview pending documentation labels

	1 Warning
	New migrations added but db/structure.sql wasn't updated Usually, when adding new migrations, db/structure.sql should be updated too (unless the migration isn't changing the DB schema and isn't the most recent one).

	2 Messages
	This merge request adds or changes files that require a review from the Database team.
	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

db/migrate/20231109133153_drop_idx_namespaces_on_ldap_sync_last_successful_update_at_for_gitlab.rb
db/schema_migrations/20231109133153

Documentation review

The following files require a review from a technical writer:

db/docs/namespaces.yml (Link to current live version)

The review does not need to block merging this merge request. See the:

Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
The Technical Writer assigned for that stage and group.
Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
database	`@jarka` (UTC+1, same timezone as author)	`@DylanGriffith` (UTC+11, 10 hours ahead of author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

removed docs-only label

Database migrations (on the main database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20231109133153 - DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab	Regular	4.1 s		-359.76 MiB

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	4
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20231109133153 - DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab

Type: Regular
Duration: 4.1 s
Database size change: -359.76 MiB

Calls

Total Time

Max Time

Mean Time

Rows

Query

1

17.2 ms

0

DROP INDEX CONCURRENTLY "index_namespaces_on_ldap_sync_last_successful_update_at"

1

5.9 ms

1

SELECT "feature_gates"."key", "feature_gates"."value"  FROM "feature_gates"  WHERE "feature_gates"."feature_key" = $1

2

0.0 ms

2

SELECT pg_backend_pid()

Histogram for DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	4
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-2505593-11839313-main`	2023-11-09T13:52:57Z	2023-11-09T11:37:29Z	2023-11-10 01:57:10 +0000
`database-testing-2505593-11839313-ci`	2023-11-09T13:52:57Z	2023-11-09T12:44:59Z	2023-11-10 01:57:10 +0000

Job artifacts

Database migrations (on the ci database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20231109133153 - DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab	Regular	4.9 s		-8.00 KiB

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	3
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20231109133153 - DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab

Type: Regular
Duration: 4.9 s
Database size change: -8.00 KiB

Calls	Total Time	Max Time	Mean Time	Rows	Query
1	13.9 ms	13.9 ms	13.9 ms	0	DROP INDEX CONCURRENTLY "index_namespaces_on_ldap_sync_last_successful_update_at"
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for DropIdxNamespacesOnLdapSyncLastSuccessfulUpdateAtForGitlab

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	3
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-2505593-11839313-main`	2023-11-09T13:52:57Z	2023-11-09T11:37:29Z	2023-11-10 01:57:10 +0000
`database-testing-2505593-11839313-ci`	2023-11-09T13:52:57Z	2023-11-09T12:44:59Z	2023-11-10 01:57:10 +0000

Job artifacts

Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

added database-testing-automation label

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

@terrichu - Can I please get your database review?

requested review from @terrichu

marked this merge request as ready

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for b649aa6f

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Create           | 40     | 0      | 7       | 0     | 47    | ✅     |
| Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
| Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 201    | 0      | 10      | 0     | 211   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

approved this merge request

added databasereviewed label and removed databasereview pending label

removed review request for @terrichu

@terrichu, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

requested review from @ghavenga

added pipeline:skip-undercoverage label

approved this merge request

resolved all threads

merged

Hello @praba.m7n

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning: