Skip to content

Draft: Do not prompt for TW reviews on contributor docs

Sarah German requested to merge 428675-contributor-docs-bot-msg into master

What does this MR do and why?

Updates Danger to not prompt for Technical Writing reviews on Contributor pages.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/397788 Closes #428675 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Check out this branch.
  2. Edit a docs page outside of /doc/development and make a commit.
  3. Run danger locally: bin/rake danger_local

You should see the prompt for a TW review:

Messages:
- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.
  1. Reset your test commit from step 2 and undo the docs change.
  2. Edit a docs page within /doc/development and make a commit.
  3. Run danger locally: bin/rake danger_local
  4. You should not see the prompt for a TW review.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #428675 (closed)

Edited by Sarah German

Merge request reports