Draft: Do not prompt for TW reviews on contributor docs
What does this MR do and why?
Updates Danger to not prompt for Technical Writing reviews on Contributor pages.
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/397788 Closes #428675 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Check out this branch.
- Edit a docs page outside of
/doc/development
and make a commit. - Run danger locally:
bin/rake danger_local
You should see the prompt for a TW review:
Messages:
- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.
- Reset your test commit from step 2 and undo the docs change.
- Edit a docs page within
/doc/development
and make a commit. - Run danger locally:
bin/rake danger_local
- You should not see the prompt for a TW review.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #428675 (closed)
Edited by Sarah German