Skip to content

Resolve confirm discard modal showing when saving a new custom dashboard

Jiaan Louw requested to merge 428757-fix-saving-dashboard-shows-confirm-discard-dialog into master

What does this MR do and why?

Fixes an issue where the confirm discard modal would get rendered after saving a new dashboard for Confirm discard changes modal is shown when sav... (#428757 - closed).

This happened because when a new dashboard is saved we redirect to it, triggering the router hook. The fix is to ignore the confirmation if we're busy saving.

Screenshots or screen recordings

Before After
Screen_Recording_2023-10-20_at_16.49.24 Screen_Recording_2023-10-20_at_16.48.14

How to set up and validate locally

  1. Follow these instructions to setup Product Analytics in GDK.
  2. Onboard Product Analytics by setting up the feature at Project > Analytics > Analytics dashboards.
  3. Navigate back to Project > Analytics > Analytics dashboards and click on New dashboard at the top right.
  4. Create a dashboard with a custom description and click save.
  5. Confirm that the modal no longer shows.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #428757 (closed)

Edited by Jiaan Louw

Merge request reports