Skip to content

Use fast_spec_helpers in all Danger specs

Peter Leitzen requested to merge pl-danger-specs-fast-spec-helper into master

What does this MR do and why?

Without, specs are not run in random order even if not excluded in spec/support/rspec_order_todo.yml.

Spotted in !134297 (comment 1610962984).

How to set up and validate locally

# On this branch
changed_specs=$(git diff --name-only HEAD~ | grep _spec.rb)
bin/rspec --format documentation $changed_specs 2>/dev/null | grep "# order random"
  # order random
  # order random
  # order random
  # order random
  # order random
  # order random
  # order random
...

# On "master"
git checkout master
bin/rspec --format documentation $changed_specs 2>/dev/null | grep "# order random"
# empty

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports