Skip to content

Fix state leaking across specs

Heinrich Lee Yu requested to merge fix-broken-master-428361 into master

What does this MR do and why?

Issue is being updated in the previous test example and should have been rolled back, but for some reason the Action Cable process in the next test still sees the issue as confidential

To reproduce the failure, just run:

bundle exec rspec './spec/features/projects/issues/email_participants_spec.rb'

This is also related to the upgrade of vue-apollo because in 3.1.0, failed subscriptions now get retried. The retrying behavior causes our spec teardown to not work properly so the spec fails.

Previously, the spec still passes even with the failed subscription because the test isn't related to the subscription.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports