Hide private group names and source in members page
What does this MR do and why?
Related issue: #415165 (closed)
Hide private group names in members page
If an invited group in project / group members page is not visible by the current user, we mask the group name, and membership source.
Visibility is determined by:
- the current user can read the invited group, or
- the current user is a member of the project / group.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After | |
---|---|---|
Project membership, User is member of project: | ||
Project membership, user Logged out: | ||
Group membership, User is member of group: | ||
Group membership, user Logged out: |
How to set up and validate locally
** Group membership
- Create a top-level public group. Let's call it
public-a
- Create a top-level private group. Let's call this
private-a
- Go to
public-a
group. Go to the group's Manage, Members page. ClickInvite a group
. Invite theprivate-a
group. - In an incognito window, open the same page. You should see the private group name's as
Private
now.
** Project membership
- Create another top-level private group. Let's this
private-b
- Create a new project in
public-a
group. - For this project, go to Manage, Members page. Click
Invite a group
. Invite theprivate-b
group. - In an incognito window, open the same page. You should see the private group name's as
Private
now.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Thong Kuah