Fix the assert_named_queries logic
What does this MR do and why?
The issue was excludes_named_query
was overwriting has_named_query
which causes all the tests to pass even the query was not present in the call.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @rkumar555
- A deleted user
added backend label
1 Warning There were no new or modified SaaS feature YAML files detected in this MR. For guidance on when to use a SaaS feature, please see the SaaS feature documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend mallocke
(UTC+13, 11 hours ahead of
@rkumar555
)jarka
(UTC+2, same timezone as
@rkumar555
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Ravi Kumar
@rkumar555 - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added Category:Global Search groupglobal search typebug labels
added devopsdata stores sectioncore platform labels
changed milestone to %16.6
- Resolved by Madelein van Niekerk
@rkumar555 thank you for fixing that!
@maddievn are you available for a maintainer review here? (It turns out that we broke it in Allow excluding archived projects from merge re... (!126024 - merged)
)
requested review from @maddievn
@dgruzd
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 3af7b5df succeeds
mentioned in commit 81b3b07b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label