Skip to content

Geo Sites Form - Migrate Shards Dropdown

Zack Cuddy requested to merge 418102-geo-refactor-shards-dropdown into master

What does this MR do and why?

Closes #418102 (closed)
Very similar to !133766 (merged)

This change migrates the GlDropodown found in ee/app/assets/javascripts/geo_site_form/components/geo_site_form_shards.vue over to GlCollapsibleListbox as part of the Pajamas Migration Epic.

This change aims to add as little visual or functional changes as possible.

With the migration of both !133766 (merged) and this MR we can remove the manual adding and removing of array options that was previously used with GlDropdown since the @selected event passes the entire array each time it is fired.

Screenshots or screen recordings

Before After
Before After

How to set up and validate locally

  1. Fetch and checkout this branch
  2. Setup Geo by following the 1-line installation in the Easy Installation section (How to setup Geo)
  3. Access your Primary GDK UI
  4. Navigate to the Geo Sites Page (ex. http://127.0.0.1:3000/admin/geo/sites)
  5. Click the Add site button in the top right
  6. Click the Selective synchronization dropdown and choose "Projects in certain storage shards"
  7. In the following dropdown, ensure you can select multiple items, deselect items, and ultimately save
  8. Once saved ensure the Site Card says Selective (shards)
  9. Edit the site
  10. Ensure the selected items are retained and can be updated

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418102 (closed)

Merge request reports