Improve `script` with `trigger` error message (!134409) · Merge requests · GitLab.org / GitLab

Avielle Wolfe requested to merge 408238-no-trigger-with-script into master Oct 17, 2023

What does this MR do and why?

The script and trigger CI keywords cannot be used together, but the existing error message wasn't clear. This MR adds a mutually exclusive validator to Entry::Processable that ensures that the user gets an understandable error.

It also rewords the error from MutuallyExclusiveValidator for clarity. The validator was not being used anywhere, so this is a safe change to make

Changelog: fixed

Screenshots or screen recordings

Before

After

How to set up and validate locally

In the CI editor, paste this config:

test_job: trigger: root/component-project script: ls

See that you get an error reading these keys cannot be used together: script, trigger

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

I have evaluated the MR acceptance checklist for this MR.

Related to #408238 (closed)

Improve `script` with `trigger` error message