Skip to content

Convert search type indicator to Vue

Tomas Bulva requested to merge 423845-rewrite-advanced_search_status_marker-to-be-vue-app into master

What does this MR do and why?

This is almost 1:1 rewrite of search type indicator The only difference is new one supports zoekt disabled When you attempt to zoekt search on non-main branch indicator sill show zoekt disabled message with explanation

Screenshots or screen recordings

This is a technical depth change. There will be no impact on UI.

Before After
Screenshot_2023-10-20_at_17.48.21 Screenshot_2023-10-20_at_17.48.21
Screenshot_2023-11-03_at_15.56.58 Screenshot_2023-11-03_at_15.56.58
Screenshot_2023-11-03_at_15.55.05 Screenshot_2023-11-03_at_15.55.05

How to set up and validate locally

  1. Make sure advanced search is installed and enabled
  2. Setup Zoekt search
  3. Visit the search page on several scopes including code in the namespace that is being indexed by Zoekt http://gdk.test:3000/search?scope=blobs&search=test&group_id=YOUR-NAMESPACE
  4. Check the states of the search type indicator

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #423845 (closed)

Edited by Tomas Bulva

Merge request reports