Skip to content

Migrate filtered search bar sort to GlSorting

What does this MR do and why?

Migrate filtered search bar sort to GlSorting

This opts in to the updated form of GlSorting to use a GlCollapsibleListbox rather than the deprecated GlDropdown.

Most of the feature spec changes fix actions/finders for interacting with the sort dropdown. The selectors are now more semantic.

The Features::SortingHelper#pajamas_sort_by method was updated to expect a from parameter, inspired by Capybara's select action.

One other notable change is that GlSorting's sort direction button tooltip and ARIA label now have the same value, which required a few more feature spec fixes.

Addresses #425440 (closed).

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Visit a page which uses FilteredSearchBarRoot:
  2. Observe that sort dropdown/direction button still work.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #425440 (closed)

Edited by Mark Florian

Merge request reports