Skip to content

Fix styling of integration details avatar

Dan Mizzi-Harris requested to merge fix-integration-details-avatar-danmh into master

What does this MR do and why?

This avatar was inside a h2 element causing some styles to leak through.

This MR moves the avatar outside of the h2, ensuring the right styles display, and possibly better semantics.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
127.0.0.1_3000_flightjs_Flight_-_settings_integrations_apple_app_store_edit 127.0.0.1_3000_flightjs_Flight_-settings_integrations_apple_app_store_edit__1
Screenshot_2023-10-16_at_16.43.26 Screenshot_2023-10-16_at_16.40.51

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to Project > Settings > Integrations
  2. View details of any integration without an image
  3. See avatar with fallback
  4. Go to Group > Settings > Integrations
  5. View details of any integration without an image
  6. See avatar with fallback
  7. Go to Admin > Settings > Integrations
  8. View details of any integration without an image
  9. See avatar with fallback

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan Mizzi-Harris

Merge request reports