Skip to content
Snippets Groups Projects

Migrate GlDropdown to GlDisclosureDropdown

Merged Thomas Hutterer requested to merge 418047-migrate-dropdown into master

What does this MR do and why?

Migrates one deprecated GlDropdown as part of the Pajamas Migration Day.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418047 (closed)

Edited by Thomas Hutterer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Hutterer added 3285 commits

    added 3285 commits

    • eb48b235...75ec9185 - 3281 commits from branch master
    • 2cac5b6d - Migrate GlDropdown to GlDisclosureDropdown
    • d12a43a3 - Replace JS nav spec with native href check
    • 7a78cdcd - Focus first item on keyboard down key
    • c0fe01e6 - Add sr-only info for per-file additions and deletions

    Compare with previous version

  • Contributor
    2 Warnings
    :warning: d12a43a3: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
    :warning:

    This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components:

    • app/assets/javascripts/vue_shared/components/diff_stats_dropdown.vue

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend @aalakkad profile link current availability (UTC+3, 2 hours ahead of author) @arfedoro profile link current availability (UTC+1, same timezone as author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 6fe87ddf and e5761e65

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.11 MB 4.12 MB - 0.0 %
    mainChunk 3.06 MB 3.06 MB - 0.0 %

    :fearful: Significant Growth: 3

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.groups.wikis.diff 196.35 KB 297.43 KB +101.08 KB 51.5 %
    pages.projects.wikis.diff 199.79 KB 300.87 KB +101.08 KB 50.6 %
    pages.projects.compare.show 344.57 KB 368.88 KB +24.31 KB 7.1 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 6fe87ddf. So we have used data from: 0c3f7034.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Olena Horal-Koretska
  • mentioned in issue gitlab-ui#2374

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading