Use BaseProjectService for CreateRuleService
requested to merge gitlab-community/gitlab:416381-protected-packages-graphql-mutation-create-package-protection-rule-follow-up-base-service-refactoring into master
What does this MR do and why?
refactor: Use BaseProjectService for CreateRuleService
This MR changes the parent class of the Packages::Protection::CreateRuleService from BaseService to BaseProjectService because BaseService should not be used anymore, see https://gitlab.com/gitlab-community/gitlab/-/blob/master/app/services/base_service.rb#L3 .
Screenshots or screen recordings
This MR contains only backend -related changes that do not change the behavior.
How to set up and validate locally
This MR does not add or change a feature. Local validation is not necessary.
Todos
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR. -
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
-
Related to #416381 (closed)
Edited by Gerardo Navarro