Skip to content

Migrate webhook resend request button

Dan MH requested to merge 416065-migrate-button-danmh into master

What does this MR do and why?

Completes community contribution !125816 (closed) that has been idle

Migrate button_tag and link_to buttons

When the request data is too large, the button is disabled. Disabled button was unable to show the tooltip. I've moved the tooltip to a wrapping div element.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-10-13_at_15.22.31 Screenshot_2023-10-13_at_15.13.44
Screenshot_2023-10-13_at_15.22.12 Screenshot_2023-10-13_at_15.13.04

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. EE licence required
  2. Go to Any Group > Settings > Webhooks
  3. Add new webhook, for example url: https://example.com
  4. Add some test events using the Test dropdown
  5. Edit this webhook
  6. Scroll to recent events table at the bottom
  7. View details
  8. Remove this webhook just in case

I was unable to mock a oversize request, so I tested by commenting out code. I think this is low risk as the button does not actually submit anything

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416065 (closed)

Edited by Dan MH

Merge request reports