Skip to content

Remove api_keyset_pagination_multi_order FF

Jarka Košanová requested to merge 422999-remove-ff into master

What does this MR do and why?

It removes api_keyset_pagination_multi_order feature flag.

The feature flag was globally enabled 26th September 2023 and there were no issues observed. We can safely remove it.

How to set up and validate locally

  1. Visit the endpoint with offset pagination (old)

    curl -i --header "Authorization: Bearer TOKEN" "https://gdk.test:3443/api/v4/users?per_page=10&page=1"

  2. Check the headers include offset pagination headers (eg. url includes page param, headers include X-Next-Page, X-Page, or X-Total-Pages`

  3. Visit the endpoint with keyset pagination (new)

    curl -i --header "Authorization: Bearer TOKEN" "https://gdk.test:3443/api/v4/users?pagination=keyset&per_page=10&page=1"

  4. Check the headers include url in headers, url should include cursor. The headers should not include X-Next-Page, X-Page, or X-Total-Pages`

  5. Check with other orderings we support for the endpoint (id, name, username), eg.

    curl -i --header "Authorization: Bearer TOKEN" "https://gdk.test:3443/api/v4/users?pagination=keyset&order_by=username&sort=asc&per_page=10&page=1"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #422999 (closed)

Merge request reports