Skip to content

Pajamas migrations

Dan MH requested to merge danmh-migrate-diff-file-button into master

What does this MR do and why?

Diff fork cancel button

Screenshots or screen recordings

Before After
Screenshot_2023-10-13_at_12.55.25 Screenshot_2023-10-13_at_12.50.30

How to set up and validate locally

I couldn't work out how to get this to display. In app/assets/javascripts/diffs/components/diff_file.vue

  • delete L404
  • remove v-else from L423
  1. Force the button to display following the instructions above
  2. Go to an MR with file changes
  3. Go to the changes tab

Closes #428141 (closed)

Diff truncated error retry button

Screenshots or screen recordings

Before After
Screenshot_2023-10-13_at_13.35.10 Screenshot_2023-10-13_at_13.25.00

How to set up and validate locally

I couldn't work out how to get this to display. In app/assets/javascripts/notes/components/diff_with_note.vue

  • delete v-if="error" from L129
  • delete L135–L139
  1. Force the button to display following the instructions above
  2. Go to an MR with text file changes
  3. Add a comment to the file
  4. See changes in MR Activity list

Closes #428150 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan MH

Merge request reports