Migrate GlDropdown to GlCollapsibleListbox
What does this MR do and why?
Migrates one deprecated GlDropdown
Vue component to the newer GlCollapsibleListbox
.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to http://gdk.test:3000/admin/runners and click the "..." dropdown on the top-right.
- Click "Show runner installation and registration instructions"
- In the modal, check the Architecture dropdown.
- Change the platform and see the contents of the dropdown change.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #418092 (closed)
Merge request reports
Activity
assigned to @thutterer
- A deleted user
added frontend label
2 Warnings This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/runner_instructions/instructions/runner_cli_instructions.vue
Testid Selectors
The following changed lines in this MR contain testid selectors:
- file
app/assets/javascripts/vue_shared/components/runner_instructions/instructions/runner_cli_instructions.vue
: -
-
data-testid="architecture-dropdown-item"
-
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend ramistry
(UTC+5.5, 3.5 hours ahead of
@thutterer
)ankit.panchal
(UTC+5.5, 3.5 hours ahead of
@thutterer
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits eba7ca88 and d80d1057
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.21 MB 4.21 MB - 0.0 % mainChunk 3.08 MB 3.08 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.runners.index 906.61 KB 948.48 KB +41.86 KB 4.6 % pages.groups.runners.index 923.01 KB 964.87 KB +41.86 KB 4.5 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for eba7ca88. So we have used data from: bab6abff.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d80d1057expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 33 | 0 | 0 | 0 | 33 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Create | 32 | 0 | 5 | 0 | 37 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 13 | 0 | 1 | 0 | 14 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 155 | 0 | 8 | 0 | 163 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
changed milestone to %16.5
- Resolved by Jannik Lehmann
@robyrne Can you please review this Pajamas Migration Day MR? Thanks!
requested review from @robyrne
- Resolved by Thomas Hutterer
- Resolved by Thomas Hutterer
@robyrne
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @jannik_lehmann and removed review request for @robyrne
@thutterer Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.Thanks for working on this @thutterer and for the great initial review @robyrne, nothing to add, let's get it over the line
enabled an automatic merge when the pipeline for 287704c1 succeeds
mentioned in commit 830e5ac1
added workflowstaging-canary label
mentioned in issue gitlab-org/manage/foundations/team-tasks#304
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added FY23Q3 label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label