Skip to content
Snippets Groups Projects

Migrate GlDropdown to GlCollapsibleListbox

Merged Thomas Hutterer requested to merge 418092-migrate-dropdown into master
All threads resolved!

What does this MR do and why?

Migrates one deprecated GlDropdown Vue component to the newer GlCollapsibleListbox.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  • Go to http://gdk.test:3000/admin/runners and click the "..." dropdown on the top-right.
  • Click "Show runner installation and registration instructions"
  • In the modal, check the Architecture dropdown.
  • Change the platform and see the contents of the dropdown change.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418092 (closed)

Edited by Thomas Hutterer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ross Byrne approved this merge request

    approved this merge request

  • :wave: @robyrne, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Ross Byrne requested review from @jannik_lehmann and removed review request for @robyrne

    requested review from @jannik_lehmann and removed review request for @robyrne

  • Contributor

    @thutterer Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #quality Slack channel.

  • Thomas Hutterer added 1 commit

    added 1 commit

    • d80d1057 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jannik Lehmann approved this merge request

    approved this merge request

  • Thanks for working on this @thutterer and for the great initial review @robyrne, nothing to add, let's get it over the line :tada:

  • Jannik Lehmann resolved all threads

    resolved all threads

  • Jannik Lehmann enabled an automatic merge when the pipeline for 287704c1 succeeds

    enabled an automatic merge when the pipeline for 287704c1 succeeds

  • merged

  • Jannik Lehmann mentioned in commit 830e5ac1

    mentioned in commit 830e5ac1

  • added workflowstaging label and removed workflowcanary label

  • added FY23Q3 label

  • Sam Beckham added FY24Q4 label and removed FY23Q3 label

    added FY24Q4 label and removed FY23Q3 label

  • Sam Beckham added FY24Q3 label and removed FY24Q4 label

    added FY24Q3 label and removed FY24Q4 label

  • Please register or sign in to reply
    Loading