Allow you to pass docker options to the Sitespeed docker;
What does this MR do and why?
Allows you to pass docker options to the docker container
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- [✓] I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @nvalenzuela_paciolan
same change I made in the other template - !86721 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14454 (closed)
requested review from @allison.browne
- Resolved by Hordur Freyr Yngvason
@allison.browne do you have a minute to look at this community contribution? Or is there someone else in Verify who should take a look?
requested review from @shinya.maeda
removed review request for @allison.browne
mentioned in issue gitlab-org/quality/triage-reports#14491 (closed)
added devopsdeploy typefeature labels
added sectioncd label
Setting label(s) groupenvironments based on devopsdeploy.
added groupenvironments label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cbbb5f7eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 11 | 0 | 212 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @hfyngvason and removed review request for @shinya.maeda
- Resolved by Hordur Freyr Yngvason
Thanks for the contribution @nvalenzuela_paciolan. This makes sense to me, but this is not a breaking change, so could you please also add this to
lib/gitlab/ci/templates/Verify/Browser-Performance.gitlab-ci.yml
? When ready, please ping me again for another review.
removed review request for @hfyngvason
requested review from @marcel.amirault
added Technical Writing label
removed review request for @marcel.amirault
added citemplates label
requested review from @marcel.amirault
mentioned in merge request !136134 (closed)
changed milestone to %16.6
removed milestone %16.6
removed review request for @marcel.amirault
added 1 commit
- 64aecac8 - Update browser_performance_testing.md with SITESPEED_DOCKER_OPTIONS
added 1 commit
- cbbb5f7e - changing other browser-performance to add sitespeed docker options
added 1 commit
- cbbb5f7e - changing other browser-performance to add sitespeed docker options
- Resolved by Hordur Freyr Yngvason
@hfyngvason
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
3 Warnings cbbb5f7e: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Labels missing: please ask a reviewer or maintainer to add documentation to this merge request. 3 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the CI/CD Templates maintainers. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
- Prepare your MR for a CI/CD Template review according to the template development guide.
- Assign and
@
mention the CI/CD Template reviewer suggested by Reviewer Roulette.
The following files require a review from the CI/CD Templates maintainers:
lib/gitlab/ci/templates/Verify/Browser-Performance.gitlab-ci.yml
lib/gitlab/ci/templates/Verify/Browser-Performance.latest.gitlab-ci.yml
Documentation review
The following files require a review from a technical writer:
-
doc/ci/testing/browser_performance_testing.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer citemplates @rossfuhrman
(UTC-6)
@hfyngvason
(UTC-5)
~"Verify" Reviewer review is optional for ~"Verify" @hfyngvason
(UTC-5)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerenabled an automatic merge when the pipeline for 0a15949e succeeds
Thanks again for the contribution @nvalenzuela_paciolan! This looks good to me now
I've set it to merge when the pipeline succeeds.Don't worry about the changelog warning from our bot, I took the liberty of squashing and editing the commit message to include one.
@nvalenzuela_paciolan, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
@nvalenzuela_paciolan, congratulations for getting your first MR merged
If this is your first MR against a GitLab project, we'd like to invite and encourage you to self-nominate yourself for
First MR Merged
swag prize here.Thank you again for contributing, what's your next contribution going to be?
This message was generated automatically. You're welcome to improve it.
mentioned in commit 22d9d82c
changed milestone to %16.6
mentioned in merge request !136401 (merged)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)