Skip to content

Remove useless code. MetricDefinition.all is memorized

Jonas Larsen requested to merge 414653-remove-unused-optimization into master

What does this MR do and why?

Gitlab::Usage::MetricDefintion.all is memorized which means that recomputing the event definitions when the metric defintion files are updated always provide the same result.

This MR removes some overly clever code that I wrote when I added Gitlab::InternalEvents::EventDefinitions.

With this change no behavior will change, but the code will be simpler.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414653 (closed)

Edited by Jonas Larsen

Merge request reports