Remove duplicated purl_types in specs
What does this MR do and why?
While working on Use cbl-mariner instead of cbl_mariner purl_type (!133903 - merged) and Add support for wolfi purl type (!133902 - merged), I realized that the purl_types
definition is repeated 3 times, which makes updating purl_type
values error prone. This MR removes this duplication.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.5
requested review from @ifrenkel
assigned to @adamcohen
- Resolved by Adam Cohen
@ifrenkel can you please take a look at this when you have a chance? Thanks!
- Resolved by Igor Frenkel
- Resolved by Igor Frenkel
removed review request for @ifrenkel
added 1 commit
- 661094f5 - Use shared example instead of shared context
- Resolved by Adam Cohen
Thanks for the review @ifrenkel, back to you!
requested review from @ifrenkel
removed review request for @ifrenkel
@ifrenkel
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
changed milestone to %16.6
added missed:16.5 label
added 2494 commits
-
661094f5...8773d679 - 2492 commits from branch
427958-fix-cbl-mariner-purl-type
- cf5f9709 - Remove duplicated purl_type in specs
- c66ae6e5 - Use shared example instead of shared context
-
661094f5...8773d679 - 2492 commits from branch
added 1520 commits
-
c66ae6e5...b6459389 - 1518 commits from branch
427958-fix-cbl-mariner-purl-type
- 12e43954 - Remove duplicated purl_type in specs
- 5b57db12 - Use shared example instead of shared context
-
c66ae6e5...b6459389 - 1518 commits from branch
added 4 commits
-
5b57db12...ba8682f7 - 2 commits from branch
427958-fix-cbl-mariner-purl-type
- e983e2a7 - Remove duplicated purl_type in specs
- 5fd4a289 - Use shared example instead of shared context
-
5b57db12...ba8682f7 - 2 commits from branch
2 Warnings c7d209da: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f6222368: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @marcogreg
(UTC+8, 13 hours ahead of author)
@stanhu
(UTC-8, 3 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 526 commits
-
5fd4a289...18c6e3cb - 524 commits from branch
master
- f6222368 - Remove duplicated purl_type in specs
- c7d209da - Use shared example instead of shared context
-
5fd4a289...18c6e3cb - 524 commits from branch
requested review from @stanhu
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 5fd4a289expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 9 | 0 | 210 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
@stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 7361bbda
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label