Skip to content
Snippets Groups Projects

Remove duplicated purl_types in specs

Merged Adam Cohen requested to merge remove-purl-type-duplication into master
All threads resolved!

What does this MR do and why?

While working on Use cbl-mariner instead of cbl_mariner purl_type (!133903 - merged) and Add support for wolfi purl type (!133902 - merged), I realized that the purl_types definition is repeated 3 times, which makes updating purl_type values error prone. This MR removes this duplication.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Igor Frenkel removed review request for @ifrenkel

    removed review request for @ifrenkel

  • Adam Cohen added 1 commit

    added 1 commit

    • 661094f5 - Use shared example instead of shared context

    Compare with previous version

  • Adam Cohen requested review from @ifrenkel

    requested review from @ifrenkel

  • Igor Frenkel approved this merge request

    approved this merge request

  • Igor Frenkel removed review request for @ifrenkel

    removed review request for @ifrenkel

  • :wave: @ifrenkel, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 changed milestone to %16.6

    changed milestone to %16.6

  • Adam Cohen added 2494 commits

    added 2494 commits

    • 661094f5...8773d679 - 2492 commits from branch 427958-fix-cbl-mariner-purl-type
    • cf5f9709 - Remove duplicated purl_type in specs
    • c66ae6e5 - Use shared example instead of shared context

    Compare with previous version

  • Adam Cohen added 1520 commits

    added 1520 commits

    • c66ae6e5...b6459389 - 1518 commits from branch 427958-fix-cbl-mariner-purl-type
    • 12e43954 - Remove duplicated purl_type in specs
    • 5b57db12 - Use shared example instead of shared context

    Compare with previous version

  • Adam Cohen added 4 commits

    added 4 commits

    • 5b57db12...ba8682f7 - 2 commits from branch 427958-fix-cbl-mariner-purl-type
    • e983e2a7 - Remove duplicated purl_type in specs
    • 5fd4a289 - Use shared example instead of shared context

    Compare with previous version

  • Contributor
    2 Warnings
    :warning: c7d209da: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: f6222368: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @marcogreg profile link current availability (UTC+8, 13 hours ahead of author) @stanhu profile link current availability (UTC-8, 3 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Adam Cohen resolved all threads

    resolved all threads

  • Adam Cohen deleted the 427958-fix-cbl-mariner-purl-type branch. This merge request now targets the master branch

    deleted the 427958-fix-cbl-mariner-purl-type branch. This merge request now targets the master branch

  • Adam Cohen added 526 commits

    added 526 commits

    Compare with previous version

  • Author Developer

    @stanhu can you please provide a backend maintainer review and merge if the changes look good? Thanks!

  • Adam Cohen requested review from @stanhu

    requested review from @stanhu

  • Igor Frenkel approved this merge request

    approved this merge request

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 5fd4a289

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
    | Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 201    | 0      | 9       | 0     | 210   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Stan Hu approved this merge request

    approved this merge request

  • merged

  • @stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Stan Hu mentioned in commit 7361bbda

    mentioned in commit 7361bbda

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading