Skip to content

Be explicit about events bubbled up from CI variables drawer

Mireya Andres requested to merge ma/bubble-events-for-ci-vars-drawer into master

What does this MR do and why?

We are using the ci_variable_drawer feature flag to replace the modal with a drawer in the CI/CD Variables setting.

This MR removes v-on="$listeners" so we can be explicit about the events we're bubbling up from the CIVariablesDrawer to CiVariablesShared. This will make it clearer what the code does and how data flows from one component to another, and adds our test coverage.

I created this MR because I was working on the feature flag cleanup for this (the FF is not yet enabled in production) and noticed that we don't have tests for this on the drawer, although we have them in the modal.

There are no visible changes from this MR. The following should still work:

  • Adding a CI variable
  • Editing a CI variable
  • Deleting a CI variable
  • Searching for environments

Screenshots or screen recordings

Screen_Recording_2023-10-12_at_13.57.08

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable the ci_variable_drawer feature flag.
  2. Go to Settings > CI/CD > Variables for a group or project. If you're testing on a group, make sure you have a Premium+ license.
  3. You can use this rake task to pre-populate the environment scope dropdown.
  4. Verify that you can search environment scopes as well as add, edit, and delete CI variables.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports