Skip to content

Update dependency prometheus-client-mmap to '>= 0.28.1'

Stan Hu requested to merge sh-backport-prometheus-client-mmap-16-3 into 16-3-stable-ee

What does this MR do and why?

This backports !133485 (merged) to 16-3-stable-ee.

We've been seeing issues with client metrics being truncated after the Puma master (worker 0) process is killed. It appears that this was happening:

  1. Puma parent process starts and opens histogram_puma_master-0.db and creates a bunch of metrics, causing the file size to increase to 16K.
  2. Puma parent forks this process as worker 0.
  3. Puma worker 0 continues to add more metrics and increases the size of the metrics, from 32K to 64K, and so on.
  4. Puma worker 0 is killed.
  5. A new Puma worker forks from parent and attempts to close. Although the actual length is 64K, this new worker inherits from parent and erroneously truncates the metrics file to 16K.

Upgrading prometheus-client-mmap disables this truncation since it causes issues and doesn't really add value.

This fixes gitlab-org/ruby/gems/prometheus-client-mmap#53 (closed).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Describe in detail what merge request is being backported and why

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports