Skip to content

Remove references to cluster_id when creating deployments

Pam Artiaga requested to merge 427851-replace-deployments-clusterid-references into master

What does this MR do and why?

The reference to deployments.cluster is now delegated through the deployment_clusters association table. As a follow-up, we need to remove all references to deployments.cluster_id.

In this MR, the cluster_id is no longer set when creating Deployment records. This should be safe to remove, because:

  • for Deployments::CreateForJobService - a DeploymentCluster record is already being created
  • for Deployments::CreateService - External deployments are not compatible with the legacy cert-based cluster integrations that make use of the Deployment.cluster association.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #427851 (closed)

Edited by Pam Artiaga

Merge request reports