Skip to content

Draft: Extract analytics validation logic to component

Elwyn Benson requested to merge analytics-validation-hoc into master

What does this MR do and why?

Extracts some common validation logic out of our analytics dashboards / visualization designer into a high-order-component to be shared between both.

TODO !133259 (comment 1596908707):

suggestion (non-blocking): When I read this, I expect it to provide this error along with the normal error because of the word “additional” 😅.

WDYT about just calling this validationMessage or validationFeedback? Since for the consumer of this HoC, that's what they will be providing.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Elwyn Benson

Merge request reports