Skip to content

No-op recovery job if env is nil

Hunter Stewart requested to merge hustewart-safe-nav-env into master

Why

See Handle stuck stopping where environment has bee... (#426897 - closed)

It's possible that an Environment could be deleted between the time the job was enqueued and when it runs. This change no-ops the job in this case.

What

  • no-op in the job
  • update specs

Note I tried using &. but it raised an error related to BatchLoader's no method override, so using a one line guard clause instead. I like the guard clause readability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports