Skip to content

Remove duplicate "Skip to main content" link when logged out

Scott de Jonge requested to merge 426364-new-navigation-unauthenticated-duplicate-skip-to-content-links into master

What does this MR do and why?

The logged out header includes a "Skip to content" link as the first interactive element of the DOM.

Screenshots or screen recordings

Before After
gdk.test_3000_flightjs_Flight_-merge_requests_4__1 gdk.test_3000_flightjs_Flight_-merge_requests_4__1
gdk.test_3000_flightjs_Flight_-merge_requests_4__2 gdk.test_3000_flightjs_Flight_-_merge_requests_4
gdk.test_3000_dashboard_todos gdk.test_3000_dashboard_todos

How to set up and validate locally

  1. Enable Feature.enable(:super_sidebar_logged_out) in Rails console rails c
  2. Open GDK in incognito window
  3. Go to publically accessible page e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/4
  4. Press tab for "Skip to content" link to display in header
  5. Keep pressing tab there shouldn't be a "Skip to main content" link in the new navigation after the header
  6. In a logged in window the "Skip to main content" link is still in the new navigation

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #426364 (closed)

Edited by Scott de Jonge

Merge request reports