Skip to content

Use GraphQL to fetch canApprove permissions in review dropdown

Phil Hughes requested to merge ph/reviewDropdownApproveQuery into master

What does this MR do and why?

Changes the submit review dropdown to fetch the can approve user permissions from the GraphQL endpoint. This reduces the amount of queries on page load that merge requests need. But also fixes a bug where the approval checkbox could be shown incorrectly.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports