Skip to content

Programming language class cleanup

Jan Provaznik requested to merge jp-lang-fix into master

What does this MR do and why?

Only minor changes in ProgrammingLanguage class:

  • removes unused from_language method and unused/redundant :single definition for VBScript
  • adds separate mapping of "single line comments" for languages, so specs now test comments independently on LANGUAGE_COMMENT_FORMATS which has two benefits: a) we don't need redundant single/single_regexp definitions in LANGUAGE_COMMENT_FORMATS and b) we can test all real possibilities for singe line comments (for VBScript we relied on :single definition while in reality single_regexp is used)
  • fixes VBScript regexp issue

Related to #426815 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vitali Tatarintev

Merge request reports