Skip to content

Use `descendant_project_members_with_inactive` in group_private_service.rb

What does this MR do and why?

Related issue: #417455 (closed)

Use descendant_project_members_with_inactive in group_private_service.rb

Fixes a cross-join betwee users and members table.

As User -> project_members association has requested_at: nil, it makes sense to use descendant_project_members_with_inactive method as this method has the non_request scope.

  • Pass list of user_ids as a sub-query, instead of plucking. As members is gitlab_main_cell, and todos is likely to be also gitlab_main_cell, we can do this.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports