Corrected the column in the table to display the action icons.
What does this MR do and why?
Updating badge actions
Added truncation of the link and made it possible to click on it
Changelog: fixed
Related to #359743 (closed)
Closes #423248 (closed)
Screenshots or screen recordings
Before:
Desktop
Mobile
After:
Desktop
Mobile
Mouse hover
How to set up and validate locally
You need to go to Project > Settings > General > Badges. Add a new badge by filling out all the required fields and enter a very long link in the "Link" field. After adding it, a table should appear with the following columns: Name, Badge, URL, Actions. The Actions column was previously hidden due to the long link.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Hey @imvitalya!
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @imvitalya
This merge request will be counted as part of the running Hackathon!
Check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
added linked-issue label
@gitlab-bot ready @xanf @lohrc
added workflowready for review label and removed workflowin dev label
@xanf
@lohrc
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
@imvitalya Thank you for this contribution! This looks good to me from my end, so I approved. Since this affects the frontend, I'll copy in @ameliabauerly and @mnichols1 as well in case they have additional feedback.
Hey @imvitalya! This is great, thanks so much!
I tried this out locally, and it's working great. Here's how it looks, for me:
The one thing I was thinking - sometimes, when we truncate items, we will display the full link on hover, in a tooltip. I wonder if that's worth adding in here, so that people can see the full URL, if they want to, without having to click to open a new page?
Edited by Amelia Bauerly@ameliabauerly , Hey
Yes, you're right. I somehow missed this moment
I will add theTooltip
component to the viewHi @imvitalya
Since there are a couple of failures on the pipeline I'm pretty sure there's some work left to do (updating the specs), so I'm setting this to workflowin devFeel free to ask for another review when you're ready with
@gitlab-bot ready @xanf
mentioned in issue gitlab-org/quality/triage-reports#14362 (closed)
mentioned in issue #423248 (closed)
@lohrc
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 207 commits
-
836b33b1...cc0ab937 - 206 commits from branch
gitlab-org:master
- 70bd52df - Merge branch gitlab:master into 423248_hiden-icon-long-url
-
836b33b1...cc0ab937 - 206 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#14431 (closed)
changed milestone to %16.5
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#14606 (closed)
changed milestone to %16.6
mentioned in issue gitlab-org/quality/triage-reports#14789 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14884 (closed)
added workflowin dev label and removed workflowready for development label
added idle label
changed milestone to %16.7
@imvitalya, it seems we're waiting on an action from you for approximately two weeks.
- Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
- Do you need help in getting it ready? At any time, you can:
- If you're actually ready for a review, you can post
@gitlab-bot ready
.
This message was generated automatically. You're welcome to improve it.
added automation:author-reminded label
changed milestone to %16.8
removed review request for @xanf
@imvitalya Just wanted to check in whether you are still working on this MR?
Edited by Christina Lohrremoved idle label
@imvitalya I will close this MR due to inactivity and because another contributor has opened a related MR for this problem. Thanks either way for your efforts to work on this problem.
@imvitalya, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels